This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] MI telnet service

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: "Abid, Hafiz" <Hafiz_Abid at mentor dot com>
Cc: Gary Benson <gbenson at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Sun, 15 Jul 2012 10:13:19 +0200
Subject: Re: [patch] MI telnet service
References: <EB3B29AD43CA924DA27099BC8519237629DF36@EU-MBX-03.mgc.mentorg.com> <20120712131930.GG29236@redhat.com> <EB3B29AD43CA924DA27099BC8519237629DFEA@EU-MBX-03.mgc.mentorg.com>

On Thu, 12 Jul 2012 16:36:43 +0200, Abid, Hafiz wrote:
> I thought we are not required to follow the convention in the test program
> source. Anyway, I will fix it with the rest. Thanks for reviewing.

Like it is not worth to for example fix indentation in the existing testcases.
But checking in a new testcase with very different formatting style does not
make it easily fixable/update-able later.  At least run indent with the
options from GNU Coding Standard:
	-nbad -bap -nbc -bbo -bl -bli2 -bls -ncdb -nce -cp1 -cs -di2 -ndj -nfc1 -nfca -hnl -i2 -ip5 -lp -pcs -psl -nsc -nsob


Thanks,
Jan

References:
- [patch] MI telnet service
  - From: Abid, Hafiz
- Re: [patch] MI telnet service
  - From: Gary Benson
- RE: [patch] MI telnet service
  - From: Abid, Hafiz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]