This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: don't set the pspace on ordinary breakpoints
- From: Pedro Alves <pedro at codesourcery dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Thu, 10 Nov 2011 17:48:50 +0000
- Subject: Re: RFC: don't set the pspace on ordinary breakpoints
- References: <m3lis6h35l.fsf@fleche.redhat.com> <m362itf8b9.fsf@fleche.redhat.com> <m3d3czdind.fsf@fleche.redhat.com>
On Thursday 10 November 2011 16:52:38, Tom Tromey wrote:
> @@ -11825,6 +11811,7 @@ addr_string_to_sals (struct breakpoint *b, char *addr_string, int *found)
> if (e.error == NOT_FOUND_ERROR
> && (b->condition_not_parsed
> || (b->loc && b->loc->shlib_disabled)
> + || (b->loc && b->loc->pspace->executing_startup)
> || b->enable_state == bp_disabled))
> not_found_and_ok = 1;
Is this necessary in this patch? I though this was related to
the new errors thrown from the linespec changes.
Otherwise looks good to me.
--
Pedro Alves