This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Allow -data-disassemble to run with only -s option
- From: Tom Tromey <tromey at redhat dot com>
- To: John Lindal <support_0384 at newplanetsoftware dot com>
- Cc: gdb-patches at sourceware dot org, gdb at newplanetsoftware dot com
- Date: Mon, 08 Aug 2011 14:26:02 -0600
- Subject: Re: Allow -data-disassemble to run with only -s option
- References: <587BFD3C-0540-49FA-87F9-89CBBF2FF010@newplanetsoftware.com>
>>>>> "John" == John Lindal <support_0384@newplanetsoftware.com> writes:
John> Since the "disassemble" command only requires the function name, I
John> figured it would be nice if -data-disassemble did not require the
John> ending address. The attached patch makes the end address (-e option)
John> optional. This is backward compatible, since all existing code that
John> calls -data-disassemble passes both -s and -e.
Do you have a copyright assignment in place?
If not, contact me off-list and I will get you started.
This patch needs a documentation update.
A test case would be nice.
A few minor nits.
John> + if (!line_seen && !file_seen && !num_seen && start_seen &&
John> !end_seen)
Your mailer mangled the patch.
John> + {
John> + char* ignore_name;
Wrong formatting, "char *ignore_name".
John> + CORE_ADDR ignore_low;
John> + if (find_pc_partial_function (low, &ignore_name, &ignore_low,
Blank line between declarations and code.
Tom