This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: sim: automatically pass down sysroot
- From: Mike Frysinger <vapier at gentoo dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: toolchain-devel at blackfin dot uclinux dot org, gdb-patches at sourceware dot org
- Date: Fri, 27 May 2011 14:37:09 -0400
- Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot
- References: <1306440200-25087-1-git-send-email-vapier__8251.52545371584$1306440225$gmane$org@gentoo.org> <m3boyovxws.fsf@fleche.redhat.com>
On Fri, May 27, 2011 at 13:46, Tom Tromey wrote:
> Mike> + Âstrcat (arg_buf, gdb_sysroot);
>
> It seems like this will give wrong results if the sysroot needs quoting.
> But, this problem could affect other arguments here.
> Offhand it seems like it would be better if this code directly built
> sim_argv rather than building a string and converting it, but I don't
> know if any odd issue is lurking.
i thought of that, but since as you say other parts have the same
issue, and i couldnt find a helper func that would sanely take care of
things, i didnt bother
-mike