This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: sim: automatically pass down sysroot
- From: Tom Tromey <tromey at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Fri, 27 May 2011 11:46:59 -0600
- Subject: Re: [PATCH] gdb: sim: automatically pass down sysroot
- References: <1306440200-25087-1-git-send-email-vapier__8251.52545371584$1306440225$gmane$org@gentoo.org>
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> 2011-05-26 Mike Frysinger <vapier@gentoo.org>
Mike> * remote-sim.c (gdbsim_open): Add the strlen of " --sysroot=" and
Mike> gdb_sysroot to the "len" variable. Append both to "arg_buf".
It seems reasonable to me. Ok.
Mike> + strcat (arg_buf, gdb_sysroot);
It seems like this will give wrong results if the sysroot needs quoting.
But, this problem could affect other arguments here.
Offhand it seems like it would be better if this code directly built
sim_argv rather than building a string and converting it, but I don't
know if any odd issue is lurking.
Tom