This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Testsuite centralize -DSYMBOL_PREFIX uses
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Date: Tue, 24 May 2011 09:51:07 +0100
- Subject: Re: [RFA] Testsuite centralize -DSYMBOL_PREFIX uses
- References: <005001cc19e6$fe446750$facd35f0$@muller@ics-cnrs.unistra.fr>
On Tuesday 24 May 2011 08:48:38, Pierre Muller wrote:
> +# gdb_target_symbol_prefix_flags returns a string that can be added
> +# to gdb_compile options to define SYMBOL_PREFIX macro value
> +# symbol_prefix_flags returns a string that can be added
> +# for targets that use underscore as symbol prefix.
> +# The list of targets is incomplete and should be enhanced as
> +# reports about missing targets come in.
This sentence is useless, IMO.
> +# TODO: find out automatically if the target needs this.
> +
> +proc gdb_target_symbol_prefix_flags {} {
> +if { [istarget "*-*-cygwin*"] || [istarget "i?86-*-mingw*"]
Missing indentation.
> + || [istarget "*-*-msdosdjgpp*"] || [istarget "*-*-go32*"]
> + || [istarget "arm*-*-wince*"] || [istarget "arm*-*-mingwce*"]} {
> + return "additional_flags=-DSYMBOL_PREFIX=\"_\""
ARM Windows CE is not underscored. Is DJGPP/GO32? bfd/config.bfd
appears to indicate it isn't. None of the places you touched listed
wince or djgpp, afaics.
> + } else {
> + return ""
> + }
> +}
> +
--
Pedro Alves