This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove set debug lin-lwp-async, new ui_file.to_write_async_safe
On Fri, May 13, 2011 at 12:05 PM, Stan Shebs <stanshebs@earthlink.net> wrote:
> On 5/13/11 10:32 AM, Doug Evans wrote:
>>
>> ? ? ? ? (stdio_file_write_async_safe): New function.
>
> FYI, my build moans about the unchecked result of write() in this, although
> it's not clear what one ought to do with a result.
Yeah. The gcc I was using doesn't warn about this.
Hui Zhu checked in a fix using the same style as the rest of the file
(which was the right thing to do, at least at the moment).
I added a comment because
if (foo ())
;
is so not what I expect to avoid warnings of this kind.
And it looks like the gcc gods decided (void) foo (); wasn't ok. Sigh.
I didn't add comments to the other invocations, but I wouldn't mind them.