Re: [RFA] Remove set debug lin-lwp-async, new ui_file.to_write_async_safe

[Doug Evans <dje at google dot com>]

On Wed, May 11, 2011 at 8:49 AM, Doug Evans <dje@google.com> wrote:
> On Wed, May 11, 2011 at 12:39 AM, Jan Kratochvil
> <jan.kratochvil@redhat.com> wrote:
>> On Wed, 11 May 2011 00:19:36 +0200, Doug Evans wrote:
>>> If it became an issue, one could record fileno ahead of time.
>>
>> Isn't it simple enough in stdio_file_new?
>
> Sounds like what I would do.
>
>>> For gettext(), I'd be happy with just removing it for this particular case.
>>
>> One can call it from _initialize_ui_file. ?There are no catalogues now but
>> they should be.
>
> If it's important enough, sure.

Here's the patch I checked in.

2011-05-13  Doug Evans  <dje@google.com>

        * linux-nat.c (debug_linux_nat_async): Delete.
        Replace all references to use debug_linux_nat instead.
        (show_debug_linux_nat_async): Delete.
        (sigchld_handler): Call ui_file_write_async_safe instead of
        fprintf_unfiltered.
        (_initialize_linux_nat): Remove `set debug lin-lwp-async'.
        * ui-file.c (struct ui_file): New member to_write_async_safe.
        (null_file_write_async_safe): New function.
        (ui_file_write_async_safe): New function.
        (set_ui_file_write_async_safe): New function.
        (ui_file_new): Initialize to_write_async_safe.
        (stdio_file_write_async_safe): New function.
        (struct stdio_file): New member fd.
        (stdio_file_new): Initialize to_write_async_safe, fd.
        (stdio_file_read, stdio_file_isatty): New stdio->fd instead of
calling fileno.
        * ui-file.h (ui_file_write_async_safe_ftype): New typedef.
        (set_ui_file_write_async_safe): Declare.
        (ui_file_write_async_safe): Declare.

        doc/
        * gdb.texinfo (Completion): Update example.
        (Debugging Output): Delete `set/show debug lin-lwp-async'.

Attachment: gdb-110513-debug-lin-lwp-async-2.patch.txt
Description: Text document