This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove same-pc breakpoint notification for internal BPs
wait, sorry, I didn't send the updated version of the patch
2011-04-20 Kevin Pouget <kevin.pouget@st.com>
* breakpoint.c (describe_other_breakpoints): Do not write 'duplicate'
note if the breakpoint is internal.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 2352191..eeec497 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b,
return 0;
}
-/* Print a message describing any breakpoints set at PC. This
+/* Print a message describing any user-breakpoints set at PC. This
concerns with logical breakpoints, so we match program spaces, not
address spaces. */
@@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
struct breakpoint *b;
ALL_BREAKPOINTS (b)
- others += breakpoint_has_pc (b, pspace, pc, section);
+ others += (breakpoint_has_pc (b, pspace, pc, section)
+ && b->number > 0);
if (others > 0)
{
if (others == 1)
@@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
else /* if (others == ???) */
printf_filtered (_("Note: breakpoints "));
ALL_BREAKPOINTS (b)
- if (breakpoint_has_pc (b, pspace, pc, section))
+ if (breakpoint_has_pc (b, pspace, pc, section) && b->number > 0)
{
others--;
printf_filtered ("%d", b->number);
On Thu, Apr 21, 2011 at 5:24 AM, Kevin Pouget <kevin.pouget@gmail.com> wrote:
> On Thu, Apr 21, 2011 at 4:49 AM, Pedro Alves <pedro@codesourcery.com> wrote:
>> On Thursday 21 April 2011 09:11:29, Kevin Pouget wrote:
>>> + ? ? ? ? ? ? ? && b->number >= 0);
>>
>> Can you make those b->number > 0? ? `0' is used for
>> momentary breakpoints, which aren't user visible either.
>>
>> (as principle, please re-paste the changelog when posting
>> an updated patch, so we don't have go fish which patch
>> goes with which changelog. ?It's practicaly 0 work to re-paste
>> it, but it's not 0 work to look for it.)
>
> sure, that's two points I was hesitating about; here is the new version:
>
> 2011-04-20 ?Kevin Pouget <kevin.pouget@st.com>
> ? ? ? * breakpoint.c (describe_other_breakpoints): Do not write 'duplicate'
> ? ? ? note if the breakpoint is internal.