Re: [PATCH] Remove same-pc breakpoint notification for internal BPs

[Kevin Pouget <kevin dot pouget at gmail dot com>]

> You should usually do full regression tests for a patch. ?That is, run
> before and after, and compare.
>
> You can run just a single directory like:
>
> ?make check RUNTESTFLAGS=--directory=gdb.base

right, that's okay.

> Kevin> ? ?ALL_BREAKPOINTS (b)
> Kevin> - ? ?others += breakpoint_has_pc (b, pspace, pc, section);
> Kevin> + ? ?others += breakpoint_has_pc (b, pspace, pc, section)
> Kevin> + ? ? ?&& b->number >= 0;
>
> You need parens around the RHS here and more indentation on the second
> line.

fixed


Thanks,

Kevin
(still waiting to receive the copyright papers mailed by the FSF)

--
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 2352191..be383f2 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5397,7 +5397,7 @@ breakpoint_has_pc (struct breakpoint *b,
   return 0;
 }

-/* Print a message describing any breakpoints set at PC.  This
+/* Print a message describing any user-breakpoints set at PC.  This
    concerns with logical breakpoints, so we match program spaces, not
    address spaces.  */

@@ -5410,7 +5410,8 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
   struct breakpoint *b;

   ALL_BREAKPOINTS (b)
-    others += breakpoint_has_pc (b, pspace, pc, section);
+    others += (breakpoint_has_pc (b, pspace, pc, section)
+               && b->number >= 0);
   if (others > 0)
     {
       if (others == 1)
@@ -5418,7 +5419,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch,
       else /* if (others == ???) */
 	printf_filtered (_("Note: breakpoints "));
       ALL_BREAKPOINTS (b)
-	if (breakpoint_has_pc (b, pspace, pc, section))
+	if (breakpoint_has_pc (b, pspace, pc, section) && b->number >= 0)
 	  {
 	    others--;
 	    printf_filtered ("%d", b->number);
--