Re: [RFA] gdb.threads/*.exp: send_gdb vs. gdb_test

[Michael Snyder <msnyder at vmware dot com>]

Joel Brobecker wrote:
> > 2010-05-26  Michael Snyder  <msnyder@msnyder-server.eng.vmware.com>
> >
> > 	* gdb.threads/attach-stopped.exp: Replace send_gdb with gdb_test.
> > 	* gdb.threads/attachstop-mt.exp: Replace send_gdb with gdb_test.
> > 	* gdb.threads/gcore-thread.exp: Replace send_gdb with gdb_test.
> > 	* gdb.threads/hand-call-in-threads.exp: Replace send_gdb with gdb_test.
> > 	* gdb.threads/linux-dp.exp: Replace send_gdb with gdb_test.
> > 	* gdb.threads/print-threads.exp: Replace send_gdb with gdb_test.
> > 	* gdb.threads/pthreads.exp: Replace send_gdb with gdb_test.
> > 	* gdb.threads/schedlock.exp: Replace send_gdb with gdb_test.
> > 	* gdb.threads/sigthread.exp: Replace send_gdb with gdb_test.
>
> Looks fine to me. Just one observation...
>
>
> > Index: pthreads.exp
> [...]
> > -    send_gdb "continue\n"
> > -    gdb_expect {
> > -	-re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {}
> > +    gdb_test_multiple "continue" "continue until common routine run 15 times" {
> > +	-re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {
> > +	}
> >  	default {
> >  	    fail "continue until common routine run 15 times"
> >  	    return 0
>
> Shouldn't we delete the "default" & "timeout" sections in this case?

I left them in because they do a "return", which wouldn't happen
if they were removed.