This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] gdb.threads/*.exp: send_gdb vs. gdb_test
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 1 Jun 2010 14:48:37 -0700
- Subject: Re: [RFA] gdb.threads/*.exp: send_gdb vs. gdb_test
- References: <4BFDBBFB.8030503@vmware.com>
> 2010-05-26 Michael Snyder <msnyder@msnyder-server.eng.vmware.com>
>
> * gdb.threads/attach-stopped.exp: Replace send_gdb with gdb_test.
> * gdb.threads/attachstop-mt.exp: Replace send_gdb with gdb_test.
> * gdb.threads/gcore-thread.exp: Replace send_gdb with gdb_test.
> * gdb.threads/hand-call-in-threads.exp: Replace send_gdb with gdb_test.
> * gdb.threads/linux-dp.exp: Replace send_gdb with gdb_test.
> * gdb.threads/print-threads.exp: Replace send_gdb with gdb_test.
> * gdb.threads/pthreads.exp: Replace send_gdb with gdb_test.
> * gdb.threads/schedlock.exp: Replace send_gdb with gdb_test.
> * gdb.threads/sigthread.exp: Replace send_gdb with gdb_test.
Looks fine to me. Just one observation...
> Index: pthreads.exp
[...]
> - send_gdb "continue\n"
> - gdb_expect {
> - -re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {}
> + gdb_test_multiple "continue" "continue until common routine run 15 times" {
> + -re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {
> + }
> default {
> fail "continue until common routine run 15 times"
> return 0
Shouldn't we delete the "default" & "timeout" sections in this case?
--
Joel