This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Limit qualified completions
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 19 Aug 2009 15:57:34 -0600
- Subject: Re: [RFA] Limit qualified completions
- References: <4A8B3BB9.2070105@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> If the user attempts to complete symbols in a class or namespace,
Keith> i.e., "complete break foo::", default_make_symbol_completion_list will
Keith> return every single known global symbol in the executable.
Keith> This simplistic patch (and test case) "fixes" the problem, limiting
Keith> the matches to the appropriate symbols.
Keith> Ok?
I realize that Daniel already expressed some reservations about this
patch, in that it does not address all the scenarios. However, my view
is that this patch is an improvement over the current situation. I
asked Daniel about this off list and he seemed to be ok with moving
forward.
So, this is ok.
In addition to templates, I wonder what happens in this area if you try
to complete "Foo::~F" or a qualified Java name like "java.lang.Str".
Tom