This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][rfc] Allow GDB to search for the right libthread_db.so.1


On Wed, May 13, 2009 at 00:42, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> On Tue, May 12, 2009 at 12:16 AM, Hui Zhu <teawater@gmail.com> wrote:
>
>> 1. ?Could you please add a debug interface like "set debug
>> linux-thread 1" to let linux-thread-db.c output some debug message?
>
> This will already happen with 'set verbose on':
>
> ?try_thread_db_load_1 (void *handle)
> ?...
> ? ? ? ?if (info_verbose)
> ? ? ? ? ?printf_unfiltered (_("td_ta_new failed: %s\n"),
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? thread_db_err_str (err));
>
> ?try_thread_db_load (const char *library)
> ?...
> ? ?if (info_verbose)
> ? ? ?printf_unfiltered (_("Trying host libthread_db library: %s.\n"),
> ? ? ? ? ? ? ? ? ? ? ? ? library);
>
> etc, etc.
>
> I don't think a separate "debug linux-thread" is really necessary,
> though it is trivial to add if others "vote" for it.

This part is OK with me.

>
>> 2. ?I still peddle my idea: let libthread-db-search-path can support
>> single file. ?And a make a patch follow your patch. Wish you like it.
>> :)
>
> I don't object to the idea per se; but I believe it really solves
> a non-existant problem, and makes documentation more confusing.
>

In a linux that use readonly filesystem and don't config tmpfs with
kernel, user will more like this function than regenerate the image
and write it to flash.

>> ---
>> ?linux-thread-db.c | ? 13 +++++++++++--
>> ?1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> --- a/linux-thread-db.c
>> +++ b/linux-thread-db.c
>> @@ -642,6 +642,7 @@ thread_db_load_search (void)
>
> Unrelated question: how did you generate above diff?
> Do you maintain a separate git mirror?
>
I use quilt, a very powerful patch manage tools.

Thanks,
Hui


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]