This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][rfc] Allow GDB to search for the right libthread_db.so.1
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>, Joel Brobecker <brobecker at adacore dot com>, Hui Zhu <teawater at gmail dot com>, tromey at redhat dot com, Thiago Jung Bauermann <bauerman at br dot ibm dot com>, Eli Zaretskii <eliz at gnu dot org>, Daniel Jacobowitz <drow at false dot org>
- Date: Mon, 11 May 2009 14:12:58 +0100
- Subject: Re: [patch][rfc] Allow GDB to search for the right libthread_db.so.1
- References: <8ac60eac0904201019g7ba8056bx5e84e6bfdf5935d8@mail.gmail.com> <8ac60eac0904301618j61051e9du38b34afbc7ed64a3@mail.gmail.com> <8ac60eac0904301719w33175de2w8d1d0fd80bf0feb4@mail.gmail.com>
On Friday 01 May 2009 01:19:43, Paul Pluzhnikov wrote:
> Sorry, missed "space before parenth":
>
> < + return libpthread_name_p(so->so_name);
> > + return libpthread_name_p (so->so_name);
>
> Fix attached.
On Friday 01 May 2009 01:19:43, Paul Pluzhnikov wrote:
> handle = dlopen (library, RTLD_NOW);
I wonder if making this RTLD_LAZY until you found the correct one
wouldn't make sense?
> +static int
> +thread_db_load_search ()
^ (void)
(this function could be made to use `openat' at some point, but
gdb is already assumes PATH_MAX is largest path possible elsewhere
anyway)
I also wonder if `set sysroot' should affect this search path: I think
not, but I'm not 100% sure.
> +int libpthread_name_p (const char *name)
> +{
^ function name at column 0, please.
Other that those nits, this version looks good to me. Everyone else
has already picked on what else could have been picked on. :-)
AFAICS, this version addressed all of Daniel's concerns. Daniel,
what do you think?
--
Pedro Alves