This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove unecessary checks for macros in target.h
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 8 May 2009 08:30:06 -0700
- Subject: Re: [RFA] Remove unecessary checks for macros in target.h
- References: <003301c9cfe3$e7547ed0$b5fd7c70$@u-strasbg.fr>
> 2009-05-08 Pierre Muller <muller.u-strasbg.fr>
>
> * src/gdb/target.h: Remove all tests for already defined
> macros. All macros defined here should not be set in config
> headers anymore.
Looks good to me. Can you also remove the following comment that
now becomes obsolete?
/* If the *_hw_beakpoint functions have not been defined
elsewhere use the definitions in the target vector. */
As a followup patch, I'd go one step further and rename the macros
that do not follow the general naming scheme in that file.
For instance: STOPPED_BY_WATCHPOINT -> target_stopped_by_watchpoint.
> PS: STOPPED_BY_WATCHPOINT macro could probably also loose its unused
> parameter... Would this later patch be also welcome?
Sure. That could be taken care of as part of the renaming above.
--
Joel