This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove unecessary checks for macros in target.h
- From: David Daney <ddaney at caviumnetworks dot com>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 08 May 2009 09:44:35 -0700
- Subject: Re: [RFA] Remove unecessary checks for macros in target.h
- References: <003301c9cfe3$e7547ed0$b5fd7c70$@u-strasbg.fr>
Pierre Muller wrote:
target.h header has lots of
#ifndef A_MACRO
#define A_MACRO default_implementation
#endif
constructs.
This patch simply removes all these
unnecessary checks for macros that are not defined anymore in any
config file, nor by configure script.
(Unless the configure scripts might set macros
without having them inside their sources,
I checked all those macros by grep).
Is this OK?
I don't know if it is OK.
However, I do wonder if it would make sense to remove the macros
altogether, and just push the expansions down into the code. If we
really don't want to be able to switch in different implementations of
these things, what is the point of an added layer of abstraction?
David Daney