This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c)
Daniel Jacobowitz wrote:
On Mon, Nov 17, 2008 at 05:31:21PM -0800, Stan Shebs wrote:
DEF_VEC_O(oso_el);
static VEC(oso_el) *oso_vector;
The vector macros should follow the "space before paren" just as
everybody else does, although I note that the doc in vec.h confuses
things by not following the general rule.
FWIW, I decided to skip this space when writing other code using VEC.
I put it in after VEC_index, but not VEC. It made things much simpler
to read. But it's not strictly proper, so either way is fine with me.
The whole space-or-no-space issue is so pedantic I can barely type this
message :-) , but the reality is that if you complicate the rules to
allow some exceptions, it opens the door to interminable debates over
whether this or that construct is exception-worthy. We minimize the time
we spend thinking about this by just having the one simple rule that
mechanically applies to everything.
Stan