This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c)

Tristan Gingold wrote:

typedef struct oso_el {
Something about what this struct is for, please? And while you and I know that "oso" is short for "other source" and refers to the collection of debug info from .o files, it's new to everybody else. :-) (Getting function bounds set correctly is going to be loads of fun, ahem, I had to look at Apple's hairy code for this several months ago...)
static VEC(oso_el) *oso_vector;
The vector macros should follow the "space before paren" just as everybody else does, although I note that the doc in vec.h confuses things by not following the general rule.
#define DSYM_SUFFIX ".dSYM/Contents/Resources/DWARF/"
Again, need to say what dSYM files are, and maybe mention that the yucky wired-in string is guaranteed to have that form (or at least that we're doing the same thing as Apple's GDB).

In comments, we should prefer to say "Mach-O" rather than "macho" or "mach-o", since that is the proper name of the file format.

With these doc and formatting changes, machoread.c is OK to go into the trunk.

(Ideally we will migrate this file to the list of generic files, but we will need to check that it compiles on other hosts first.)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]