This is the mail archive of the
mailing list for the GDB project.
Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c)
- From: Stan Shebs <stan at codesourcery dot com>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 17 Nov 2008 17:31:21 -0800
- Subject: Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c)
- References: <7B1402FF-6CAB-4C6A-AAB5-81E062080FB5@adacore.com>
Tristan Gingold wrote:
Something about what this struct is for, please? And while you and I
know that "oso" is short for "other source" and refers to the collection
of debug info from .o files, it's new to everybody else. :-) (Getting
function bounds set correctly is going to be loads of fun, ahem, I had
to look at Apple's hairy code for this several months ago...)
typedef struct oso_el
The vector macros should follow the "space before paren" just as
everybody else does, although I note that the doc in vec.h confuses
things by not following the general rule.
static VEC(oso_el) *oso_vector;
#define DSYM_SUFFIX ".dSYM/Contents/Resources/DWARF/"
Again, need to say what dSYM files are, and maybe mention that the yucky
wired-in string is guaranteed to have that form (or at least that we're
doing the same thing as Apple's GDB).
In comments, we should prefer to say "Mach-O" rather than "macho" or
"mach-o", since that is the proper name of the file format.
With these doc and formatting changes, machoread.c is OK to go into the
(Ideally we will migrate this file to the list of generic files, but we
will need to check that it compiles on other hosts first.)