This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation and testcase
- From: Sérgio Durigan Júnior <sergiodj at linux dot vnet dot ibm dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 04 Nov 2008 13:01:59 -0200
- Subject: Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation and testcase
- References: <1225773088.24532.56.camel@miki> <email@example.com>
On Tue, 2008-11-04 at 08:18 +0000, Phil Muldoon wrote:
> Sérgio Durigan Júnior wrote:
> > This last part modifies the build system (in order to implement the
> > GDB's datadir), adds the documentation and the testcase for the new
> > feature.
> Nice, looks great! Just some comments on tests.
> This is a forward of a comment from the archer list on the original
> patch-set. On targets that do support syscall breakpoints, but there is
> no xml database (like on x8664) will these tests just fail? Are they
> gated to XFAIL (or however one would gracefully fail here).
Oh, sorry about this. I completely forgot about our conversation. The
way it is now, the patch will fail if the arch doesn't provide the XML
file. You're right, I need to fix this and put an XFAIL.
> My only other comment is how this would work on remote targets (i.e.
> remote target is x86, but your host is PPC).
To be completely honest, I still don't know the answer to this question.
I'd be glad if some good soul could try to answer this, so that I can
fix things if needed.
Thanks for your valid comments.
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC