This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: patch to 'help' completion
- From: Daniel Jacobowitz <drow at false dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 11 Jul 2008 10:18:37 -0400
- Subject: Re: RFA: patch to 'help' completion
- References: <m3d4lyzwfm.fsf@fleche.redhat.com>
On Mon, Jun 30, 2008 at 11:04:13AM -0600, Tom Tromey wrote:
> Yesterday I happened to notice that 'help info TAB' does not complete
> on info subcommands. This seemed like an odd oversight to me, so I
> delved into it and wrote this patch.
>
> Basically, complete_on_cmdlist only looks at the immediate subcommands
> of the current command element. In the 'help info TAB' case, this
> amounts to trying to complete "info " -- which yields nothing.
>
> Since complete_line does almost everything we want, I added an
> argument to it to omit calling individual commands' completion
> functions if we're completing for the help command.
>
> Built and tested on x86 F8. New test case included. Ok?
Looks good to me, thanks.
--
Daniel Jacobowitz
CodeSourcery