This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [gdbserver] Fix attaching notices
On Tue, Jul 08, 2008 at 02:58:33AM +0100, Pedro Alves wrote:
> > * infrun.c (handle_inferior_event): Do not ignore non-SIGSTOP while
> > attaching. Use signal_stop_state.
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Bah.
> So, we either
>
> 1) go with my patch (on which the win32 part was a hack, but I
> can live with it), and live with the bogus notice
> against older gdbservers, or
>
> 2) change the test to:
>
> if (stop_soon == STOP_QUIETLY_NO_SIGSTOP
> && stop_signal == TARGET_SIGNAL_STOP
> && stop_signal == TARGET_SIGNAL_TRAP)
Ought to be some || in there :-)
> {
> stop_stepping (ecs);
> stop_signal = TARGET_SIGNAL_0;
> return;
> }
>
> Or even add a `&& stop_signal == TARGET_SIGNAL_0', and merge
> this stop_soon with STOP_QUIETLY_REMOTE.
I don't think I understand.
Allowing both stop and trap sounds reasonable to me. We already rely
on there not being other sources of SIGTRAP.
--
Daniel Jacobowitz
CodeSourcery