This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Retrieve libraries from remote target
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: eliz at gnu dot org
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 9 May 2008 21:28:46 +0200 (CEST)
- Subject: Re: [rfc] Retrieve libraries from remote target
Eli Zaretskii wrote:
> > Date: Thu, 8 May 2008 22:21:56 +0200 (CEST)
> > From: "Ulrich Weigand" <uweigand@de.ibm.com>
> >
> > The user interface is simple: if the path specified as "sysroot" starts
> > with the string "remote:", the sysroot location is assumed to be on the
> > remote target.
>
> What if my _local_ "sysroot" happens to begin with the literal string
> "remote:"? How can I tell GDB this is not a remote location?
You cannot. Is this limitation a real problem?
> > + error (_("Could not open `%s' as an executable file: %s"),
> > + temp_pathname, bfd_errmsg (bfd_get_error ()));
>
> In other error messages, you used "..", not `..', to quote file names.
> I like `..' better, and I think we use `..' in more places than we use
> "..". I think consistency is important in user messages.
All messages in my patch were just copies from one place to another;
but I agree that they should be consistent. I'll change everything
to use `..'.
> > + if (strlen (bfd_get_filename (abfd)) >= SO_NAME_MAX_PATH_SIZE)
> > + error (_("Full path name length of shared library exceeds \
> > +SO_NAME_MAX_PATH_SIZE in so_list structure."));
>
> Is this really a useful message, especially since we don't show the
> actual value of SO_NAME_MAX_PATH_SIZE and the actual length of the
> file name? I say either show the two numbers explicitly, or just tell
> it's too long. (Yes, I know you only made a minor modification of an
> existing message.)
I think just "Shared library file name is too long." or something
similar would be enough; the user cannot really do anything in that
situation anyway ...
> Also, GNU coding standards frown on using "path name", they want us to
> use "file name". If you do that, I think you can lose the "Full"
> part.
OK.
> Finally, this needs documentation before it is committed.
Sure, I'll add that.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com