Re: [rfc] Retrieve libraries from remote target

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Thu, 8 May 2008 22:21:56 +0200 (CEST)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> 
> The user interface is simple: if the path specified as "sysroot" starts
> with the string "remote:", the sysroot location is assumed to be on the
> remote target.

What if my _local_ "sysroot" happens to begin with the literal string
"remote:"?  How can I tell GDB this is not a remote location?

> +	  error (_("Could not open `%s' as an executable file: %s"),
> +		 temp_pathname, bfd_errmsg (bfd_get_error ()));

In other error messages, you used "..", not `..', to quote file names.
I like `..' better, and I think we use `..' in more places than we use
"..".  I think consistency is important in user messages.

> +  if (strlen (bfd_get_filename (abfd)) >= SO_NAME_MAX_PATH_SIZE)
> +    error (_("Full path name length of shared library exceeds \
> +SO_NAME_MAX_PATH_SIZE in so_list structure."));

Is this really a useful message, especially since we don't show the
actual value of SO_NAME_MAX_PATH_SIZE and the actual length of the
file name?  I say either show the two numbers explicitly, or just tell
it's too long.  (Yes, I know you only made a minor modification of an
existing message.)

Also, GNU coding standards frown on using "path name", they want us to
use "file name".  If you do that, I think you can lose the "Full"
part.

Finally, this needs documentation before it is committed.

Thanks!