This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: problem with "info spu signal" command on spu-gdb
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: hidetaka dot takano at glb dot toshiba dot co dot jp (Hidetaka Takano)
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 10 Mar 2008 13:40:23 +0100 (CET)
- Subject: Re: problem with "info spu signal" command on spu-gdb
Hello Takano-san,
just some minor formatting nits:
> 2008-02-29 Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>
There should be two spaces between the name and the e-mail address.
> * spu-tdep.c (info_spu_event_command): insert a '\0' to the end
> of the data passing to strtoulst function.
Start the sentence describing the change with a capital letter.
> * spu-tdep.c (info_spu_signal_command): Likewise.
For multiple changes to the same file, it suffices to name the
file only once.
I've made those changes and committed the patch; here's the
version of the ChangeLog entry I committed:
2008-03-10 Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>
* spu-tdep.c (info_spu_event_command): Insert a '\0' to the end
of the data passing to strtoulst function.
(info_spu_signal_command): Likewise.
Thanks for fixing this problem!
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com