This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Add proper error message instead of gdb_assert

From: Daniel Jacobowitz <drow at false dot org>
To: Michael Snyder <msnyder at specifix dot com>
Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, deuling at de dot ibm dot com, gdb-patches at sourceware dot org, uweigand at de dot ibm dot com
Date: Mon, 3 Mar 2008 15:38:58 -0500
Subject: Re: [patch] Add proper error message instead of gdb_assert
References: <47CC5332.3020700@de.ibm.com> <200803031955.m23Jt7cj019540@brahms.sibelius.xs4all.nl> <1204576131.19253.582.camel@localhost.localdomain>

On Mon, Mar 03, 2008 at 12:28:51PM -0800, Michael Snyder wrote:
> On Mon, 2008-03-03 at 20:55 +0100, Mark Kettenis wrote:
> 
> > 
> > Sorry, but I don't see why your error message is "proper".  The
> > gdb_assert() should never fail; the fact that it does means that you
> > have a bug elsewhere in gdb.
> 
> Isn't that what the "internal error" call is for?

gdb_assert calls internal_error anyway.

-- 
Daniel Jacobowitz
CodeSourcery

Follow-Ups:
- Re: [patch] Add proper error message instead of gdb_assert
  - From: Markus Deuling
- Re: [patch] Add proper error message instead of gdb_assert
  - From: Markus Deuling

References:
- [patch] Add proper error message instead of gdb_assert
  - From: Markus Deuling
- Re: [patch] Add proper error message instead of gdb_assert
  - From: Mark Kettenis
- Re: [patch] Add proper error message instead of gdb_assert
  - From: Michael Snyder

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]