This is the mail archive of the
mailing list for the GDB project.
Re: [patch] Add proper error message instead of gdb_assert
- From: Michael Snyder <msnyder at specifix dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: deuling at de dot ibm dot com, gdb-patches at sourceware dot org, uweigand at de dot ibm dot com
- Date: Mon, 03 Mar 2008 12:28:51 -0800
- Subject: Re: [patch] Add proper error message instead of gdb_assert
- References: <47CC5332.firstname.lastname@example.org> <200803031955.m23Jt7cj019540@brahms.sibelius.xs4all.nl>
On Mon, 2008-03-03 at 20:55 +0100, Mark Kettenis wrote:
> Sorry, but I don't see why your error message is "proper". The
> gdb_assert() should never fail; the fact that it does means that you
> have a bug elsewhere in gdb.
Isn't that what the "internal error" call is for?
The fact that there's a bug somewhere else in gdb is not
necessarily a reason to abort the debugging session.
It COULD be that severe -- but I don't think we necessarily
need to assume it is.
If so, we might just about as well call abort from main,
because there are *always* bugs somewhere else in gdb...