This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MI Doco


> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Mon, 12 Jun 2006 18:18:14 +1200
> Cc: gdb-patches@sources.redhat.com
> 
>  > I already approved the second patch (which AFAIU was just like the one
>  > before, with my comments resolved, and I said in response to the first
>  > patch that once the comments are taken care of, you can commit).  I
>  > also approved the reordering you asked about.
> 
> Just one part of the second patch (GDB/MI Compatibility with CLI) was part of
> the previous patch.  Are you clear about/OK with this part?:
> 
> 	(GDB/MI Data Manipulation): Remove description of unimplemented
> 	display related commands as variable objects perform this function
> 	and are superior: -display-delete, -display-disable,
> 	-display-enable, -display-insert and -display-list.  Move
> 	-environment-cd, -environment-directory, -environment-path
> 	and -environment-pwd to "Program Context".

Please don't do things like that: please don't mix a corrected patch
with another as yet unseen patch, especially not in such large
patches.  I checked a few changes, saw that you fixed my comments, and
didn't look farther.  I cannot afford reading such large patches
several times; I usually trust people that when they say they took
care of my comments, they really did.

Now please post only the new parts, the ones I've never seen.  Please
don't commit anything before that.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]