This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] replace stub fn mips_eabi_return_value
- From: Michael Snyder <msnyder at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: GDB Patches <gdb-patches at sources dot redhat dot com>, Fred Fish <fnf at specifix dot com>
- Date: Mon, 12 Jun 2006 12:26:29 -0700
- Subject: Re: [RFA] replace stub fn mips_eabi_return_value
- References: <447E2CF3.4070102@redhat.com> <20060609184026.GC860@adacore.com>
Joel Brobecker wrote:
2006-05-31 Michael Snyder <msnyder@redhat.com>
* mips-tdep.c (mips_eabi_return_value): Replace stub that always
returned RETURN_VALUE_STRUCT_CONVENTION with a real function.
This looks OK to me. Just make sure to remove the two commented out
lines of code in the last "for" block.
Will do, but now that you mention it -- that comment was sort of
a reminder to myself that I should ping Fred about this issue.
Fred, your similar code for o64 also makes use of register_size.
I don't at the moment remember what the issue was, but I did run
into problems that suggested to me that stack_argsize was a better
choice -- and the change did improve things.
Any thoughts?
! for (offset = 0;
! offset < TYPE_LENGTH (type);
! /* offset += register_size (gdbarch, regnum), regnum++) */
! offset += mips_stack_argsize (gdbarch), regnum++)
! {
! /* xfer = register_size (gdbarch, regnum); */