Re: [PATCH] prevent core dump for multiple def symbols

[Daniel Jacobowitz <drow at false dot org>]

On Fri, Jun 11, 2004 at 10:53:41AM -0400, Daniel Jacobowitz wrote:
> The files in bfd/ are maintained as part of GNU Binutils, so you need
> to ask on the binutils list about this patch.
> 
> It seems obvious and correct to me.  Is multiple_definition a recent
> callback or did I just miss it when I wrote simple.c?  [I won't even
> ask how you have a shared library with multiple definitions of a
> dynamic symbol.]
>
> On Fri, Jun 11, 2004 at 03:45:26PM +0100, Fergal Daly wrote:
> > I have a .so file that makes gdb dump core. The problem shows up in
> > bfd/linker.c:1800
> > 
> > if (! ((*info->callbacks->multiple_definition)
> >   (info, h->root.string, msec->owner, msec, mval,
> >   abfd, section, value)))
> >     return FALSE;
> > 
> > because info->callbacks->multiple_definition is null.
> > 
> > I have no idea if this patch is "the right thing" but it allows me to debug
> > my app. It just sets the callback to a dummy callback which returns TRUE
> > when the link_info is being created. I presume this is OK because all the
> > other callbacks are set to dummies too.
> > 
> > This was logged as bug 1668, hopefully this is a fix for it.
> > 
> > Patch below,

I have belatedly checked in this patch, with some formatting fixes.
Tested on i686-pc-linux-gnu.

-- 
Daniel Jacobowitz