This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[rfc] Suppress printing fork attach/detach message by default (GNU/Linux)
- From: Daniel Jacobowitz <drow at false dot org>
- To: gdb-patches at sources dot redhat dot com
- Date: Mon, 6 Dec 2004 22:22:22 -0500
- Subject: [rfc] Suppress printing fork attach/detach message by default (GNU/Linux)
Is anyone particularly attached to these messages? I was fixing a bug
report (very old now) which indicated I needed to call target_terminal_ours,
and I stopped to wonder if the user really cares about this.
Generally I don't. They just get in the way.
Not yet committed; will wait to see if anyone has comments.
--
Daniel Jacobowitz
2004-12-06 Daniel Jacobowitz <dan@debian.org>
* linux-nat.c (child_follow_fork): Call target_terminal_ours before
printing output. Use fprintf_unfiltered. Only print output when
debugging.
Index: linux-nat.c
===================================================================
RCS file: /big/fsf/rsync/src-cvs/src/gdb/linux-nat.c,v
retrieving revision 1.18
diff -u -p -r1.18 linux-nat.c
--- linux-nat.c 4 Dec 2004 17:21:26 -0000 1.18
+++ linux-nat.c 7 Dec 2004 03:18:40 -0000
@@ -347,9 +347,13 @@ child_follow_fork (int follow_child)
also, but they'll be reinserted below. */
detach_breakpoints (child_pid);
- fprintf_filtered (gdb_stdout,
- "Detaching after fork from child process %d.\n",
- child_pid);
+ if (debug_linux_nat)
+ {
+ target_terminal_ours ();
+ fprintf_unfiltered (gdb_stdlog,
+ "Detaching after fork from child process %d.\n",
+ child_pid);
+ }
ptrace (PTRACE_DETACH, child_pid, 0, 0);
@@ -418,9 +422,13 @@ child_follow_fork (int follow_child)
/* Before detaching from the parent, remove all breakpoints from it. */
remove_breakpoints ();
- fprintf_filtered (gdb_stdout,
- "Attaching after fork to child process %d.\n",
- child_pid);
+ if (debug_linux_nat)
+ {
+ target_terminal_ours ();
+ fprintf_unfiltered (gdb_stdlog,
+ "Attaching after fork to child process %d.\n",
+ child_pid);
+ }
/* If we're vforking, we may want to hold on to the parent until
the child exits or execs. At exec time we can remove the old