Re: [PATCH 4/6] x86: use template for AVX/AVX512 floating point comparison insns

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Fri, Mar 6, 2020 at 6:57 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 06.03.2020 15:44, H.J. Lu wrote:
> > On Fri, Mar 6, 2020 at 12:13 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> These all follow an almost common pattern, again with the exception of
> >> being commutative, which can be easily taken care of.
> >>
> >> Note that, as an intended side effect (and in fact one of the reason to
> >> introduce templates), AVX long-form pseudo-ops get introduced alongside
> >> the already existing AVX512 ones.
> >
> > What did you mean by that?
>
> That from the current set of pseudos not all are supported in the
> AVX case. IIRC the set got expanded (also covering the AVX variants)
> when AVX512 was added to the SDM.
>
> >  We need testcases to show what were missing
> > before and they are added now.
>
> Sigh - I can do so of course, but it's tedious and pretty pointless
> with the templated templates now guaranteeing consistency.
>

Please do that.   OK with added testcases.

Thanks.

-- 
H.J.