Re: [PATCH 1/6] x86: allow opcode templates to be templated

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Fri, Mar 6, 2020 at 12:11 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> In order to reduce redundancy as well as the chance of things going out
> of sync (see a later patch for an example), make the opcode table
> generator capable of recognizing and expanding templated templates. Use
> the new capability for compacting the general purpose conditional insns.
>
> opcodes/
> 2020-03-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * i386-gen.c (struct template_arg, struct template_instance,
>         struct template_param, struct template, templates,
>         parse_template, expand_templates): New.
>         (process_i386_opcodes): Various local variables moved to
>         expand_templates. Call parse_template and expand_templates.
>         * i386-opc.tbl (cc): New. Use it for Jcc, SETcc, and CMOVcc.
>         * i386-tbl.h: Re-generate.

OK.  Thanks.

> ---
> The set* templates lack No_bSuf - is there an expectation that in AT&T
> mode a 'b' suffix may be used on them? Otherwise this should be added

What does setb do?

> imo, as being yet another omission of commit dc2be329b950 ("i386: Only
> check suffix in instruction mnemonic").
>

-- 
H.J.