Re: [PATCH] config/debuginfod.m4: Rewrite with pkg-config

[Simon Marchi <simark at simark dot ca>]

On 2020-03-03 7:15 p.m., Aaron Merey wrote:
> Hello,
> 
> This patch modifies config/debuginfod.m4 so that it takes advantage of
> debuginfod's support for pkg-config. Both binutils' and gdb's configure
> and Makefile as well as the top-level configure are regenerated in
> this patch. I also removed the call to AC_DEBUGINFOD in the top-level
> configure.ac in order to conform with the configure-time handling of
> other shared libraries used in this project (many of which are not
> handled at the top-level). I am posting this patch on this list since
> debuginfod.m4 was originally added by a patch I posted here. I have
> discussed these changes with Simon Marchi and Tom Tromey who have
> indicated their support for the gdb side.
> 
> Aaron

Indeed, we suggested to use pkg-config to find this library, given that it's
a new library that has offered a .pc since its beginnings.

Instead of calling pkg-config by hand, could we use the PKG_CHECK_MODULES
autoconf macro?  It is distributed with pkg-config, and is typically the
one used for that purpose.  We would have to pick a given pkg-config version
(such as the latest as of today) and mandate that autoreconf/aclocal is ran
with this pkg-config version.

This is very similar to how we mandate specific versions of autoconf and
automake.  We just need to install pkg-config in the same prefix as the
autoconf/automake that most of us already build by hand for that purpose, and
aclocal will find the macro.

Simon