This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Separate macro-fusible instructions from not for -mbranches-within-32B-boundaries

On 03.03.2020 04:40, Hongtao Liu wrote:
> Update my patch.

Thanks again, looks good to me now with just one minor comment:

>+enum mf_cmp_kind
>+  {
>+    mf_cmp_test_and,  /* test/cmp */

If there is a comment here, I think it should also mention AND. But
of course given the enumerator's name I'm not sure a comment is
needed in the first place. But you'll have to wait for H.J.'s
comments / okay anyway.

Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]