This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] libctf: mark swap.h inline functions as static
- From: Nick Alcock <nick dot alcock at oracle dot com>
- To: Joey Ye <joey dot ye dot cc at gmail dot com>
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>, binutils at sourceware dot org
- Date: Mon, 04 Nov 2019 10:02:40 +0000
- Subject: Re: [PATCH] libctf: mark swap.h inline functions as static
- References: <20191015025025.365312-1-simon.marchi@polymtl.ca> <87k196ccwy.fsf@esperi.org.uk> <17fee8d2-3c83-6f15-5c4b-2199f5c12b6f@polymtl.ca> <87y2xk8sik.fsf@esperi.org.uk> <CAL0py26iKbffy5An3+zox6Zp5ia6+pYx6SKcpssQ1V6BuUdH0Q@mail.gmail.com>
On 1 Nov 2019, Joey Ye outgrape:
> I believe bswap_identity_64 need to be changed to static inline as
> well. Generally C compilers are not friendly to "inline" keyword
> along.
>
> Also may I request backport this and a coming bswap_identity_64 to
> 2.33 branch please? Without this fix Binutils fails to build with
> CFLAGS=-O0 in all platforms.
Seems like a good idea. Unless someone asks me not to, I'll fold this
extra fix into the things I'm doing to fix bug 25120 (which is taking
way too long: sorry, colliding holidays and trying to get the
deduplicator debugged etc).
Probably next week though :/