This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] libctf: mark swap.h inline functions as static
- From: Joey Ye <joey dot ye dot cc at gmail dot com>
- To: Nick Alcock <nick dot alcock at oracle dot com>
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>, binutils at sourceware dot org
- Date: Fri, 1 Nov 2019 14:59:45 +0000
- Subject: Re: [PATCH] libctf: mark swap.h inline functions as static
- References: <20191015025025.365312-1-simon.marchi@polymtl.ca> <87k196ccwy.fsf@esperi.org.uk> <17fee8d2-3c83-6f15-5c4b-2199f5c12b6f@polymtl.ca> <87y2xk8sik.fsf@esperi.org.uk>
Hi Simon,
I believe bswap_identity_64 need to be changed to static inline as
well. Generally C compilers are not friendly to "inline" keyword
along.
Also may I request backport this and a coming bswap_identity_64 to
2.33 branch please? Without this fix Binutils fails to build with
CFLAGS=-O0 in all platforms.
Thanks,
Joey
On Wed, Oct 16, 2019 at 7:17 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>
> On 16 Oct 2019, Simon Marchi spake thusly:
> > On 2019-10-15 10:15 a.m., Nick Alcock wrote:
> >> (... and could anyone review the GDB testsuite fix stuff I've had
> >> outstanding for a few days now? I'm hoping I can push it and the acked
> >> stuff that is first in that patch series before everything changes under
> >> it so much I have to redo it all... :) )
> >
> > It seems like Tom has looked at it now?
>
> Yes indeed! I'll be posting a revised series shortly (probably later
> tonight).
>
> --
> NULL && (void)