This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][1/2] RISC-V: Set floating-point CSR-access instructions to alias instructions
- From: Jim Wilson <jimw at sifive dot com>
- To: Mel Chen <mel dot chen at sifive dot com>
- Cc: Binutils <binutils at sourceware dot org>, Kito Cheng <kito dot cheng at gmail dot com>, Kito Cheng <kito dot cheng at sifive dot com>
- Date: Tue, 30 Jul 2019 14:47:55 -0700
- Subject: Re: [PATCH][1/2] RISC-V: Set floating-point CSR-access instructions to alias instructions
- References: <CAH6HdcOMD72V69gYf3uMNZ8yTV_Vud5DZG10j9iQYPyuR8RyPw@mail.gmail.com>
On Tue, Jul 30, 2019 at 4:57 AM Mel Chen <mel.chen@sifive.com> wrote:
> opcodes/
> * riscv-opc.c (riscv_opcodes): Set floating-point CSR-access
> instructions to alias instructions.
>
> Set frsr, fssr, frcsr, fscsr, frrm, fsrm, fsrmi, frflags,
> fsflags, fsflagsi to alias instructions.
You have two entries for one change here. I deleted the first line.
> gas/
> * testsuite/gas/riscv/alias-csr.s: Add testcase for CSR-access
> alias instructions.
> * testsuite/gas/riscv/no-aliases-csr.d: Run testcase alias-csr.s
> with -Mno-aliases.
FYI It isn't necessary to include the ChangeLog diffs if you included
the ChangeLog text in the email like you did. The ChangeLog diffs
often fail to apply if someone else makes a change in between when you
made the patch and someone attempts to apply it. Also, the date might
be wrong if there is a delay.
This looks right. I committed and pushed it.
Jim