This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] RISC-V: enable lui relaxation for CODE and MERGE sections.
- From: Kito Cheng <kito dot cheng at gmail dot com>
- To: Jim Wilson <jimw at sifive dot com>
- Cc: Ilia Diachkov <ilia dot diachkov at optimitech dot com>, Binutils <binutils at sourceware dot org>
- Date: Tue, 23 Jul 2019 14:45:31 +0800
- Subject: Re: [PATCH] RISC-V: enable lui relaxation for CODE and MERGE sections.
- References: <36e6a5e5752cb65bc13667c50c3d105c@optimitech.com> <CAFyWVabN2rOS58aWNEKR8khkZvid_sENWpAAysQkh0vdfDN8hQ@mail.gmail.com> <CA+yXCZBe-pyPUevmORt=A1UA+bjmRRMA7VRP=JGOkSTDb079kA@mail.gmail.com>
Hi Ilia:
Forgot to attend my binutils configuration and git hash:
../binutils-gdb/configure --target=riscv32-unknown-linux-gnu
commit 89356123a17c27548c7e71f4f000b1f74e551c31
Refs: {origin/master}, {origin/HEAD},
users/ARM/embedded-gdb-master-2018q4-2078-g89356123a1
Author: GDB Administrator <gdbadmin@sourceware.org>
AuthorDate: Tue Jul 23 00:00:36 2019 +0000
Commit: GDB Admin <brobecker@adacore.com>
CommitDate: Tue Jul 23 00:00:36 2019 +0000
Automatic date update in version.in
On Tue, Jul 23, 2019 at 2:40 PM Kito Cheng <kito.cheng@gmail.com> wrote:
>
> Hi Illa:
>
> I just found a case will got `relocation truncated to fit` error on
> rv32 linux with this patch.
>
> Here is the tarball for reproduce, included minimized sysroot and
> necessary objects/libraries.
>
> `make relax` can reproduce the problem and `make norelax` for disable
> relax build.
>
> https://drive.google.com/file/d/1l-IOiK3Ay7s2mnFWYXOkHYyPFNsIV58H/view?usp=sharing
>
>
> On Tue, Jun 25, 2019 at 4:55 AM Jim Wilson <jimw@sifive.com> wrote:
> >
> > On Fri, Jun 21, 2019 at 11:59 AM Ilia Diachkov
> > <ilia.diachkov@optimitech.com> wrote:
> > > This patch enables lui relaxation for CODE and MERGE sections on RISC-V.
> > > It helps to reduce code size.
> >
> > I spotted two minor style issues. An extra blank line where we had
> > the bfd_assert call during testing. And a missing space before an
> > open paren.
> >
> > I rewrote the ChangeLog entry. It should describe the actual changes
> > that are being made, and not the effect of the change. Also, it
> > should be sentences that start with capital letter.
> >
> > I did a quick test to make sure I didn't accidentally break it and
> > then committed and pushed it.
> >
> > Jim