This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] Fix a few non-dash safe xstormy16 shell scripts.
- From: Jim Wilson <jimw at sifive dot com>
- To: binutils at sourceware dot org
- Cc: Jim Wilson <jimw at sifive dot com>
- Date: Wed, 26 Jun 2019 18:17:13 -0700
- Subject: [PATCH] Fix a few non-dash safe xstormy16 shell scripts.
Noticed by a customer while looking at a tangentially related problem. The
gas testsuite for xstormy16 has two scripts that have a typo on the first
line, they are missing the !. They also use shell syntax that doesn't work
on a system where /bin/sh is dash. So I fixed the typo, changed the shell
to bash, and made them executable, so that they now work when run directly
even if /bin/sh is dash.
I don't see an xstormy16 maintainer, so I just committed them.
Jim
gas/
* testsuite/gas/xstormy16/allinsn.sh: Change first line to
#!/bin/bash and make it executable.
* testsuite/gas/xstormy16/gcc.sh: Likewise.
---
gas/testsuite/gas/xstormy16/allinsn.sh | 2 +-
gas/testsuite/gas/xstormy16/gcc.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
mode change 100644 => 100755 gas/testsuite/gas/xstormy16/allinsn.sh
mode change 100644 => 100755 gas/testsuite/gas/xstormy16/gcc.sh
diff --git a/gas/testsuite/gas/xstormy16/allinsn.sh b/gas/testsuite/gas/xstormy16/allinsn.sh
old mode 100644
new mode 100755
index 03828f9c91..feb1a19e5b
--- a/gas/testsuite/gas/xstormy16/allinsn.sh
+++ b/gas/testsuite/gas/xstormy16/allinsn.sh
@@ -1,4 +1,4 @@
-#/bin/sh
+#!/bin/bash
# Generate test result data for xstormy16 GAS testing.
# This script is machine generated.
# It is intended to be run in the testsuite source directory.
diff --git a/gas/testsuite/gas/xstormy16/gcc.sh b/gas/testsuite/gas/xstormy16/gcc.sh
old mode 100644
new mode 100755
index 1eb8972774..5a20f9e297
--- a/gas/testsuite/gas/xstormy16/gcc.sh
+++ b/gas/testsuite/gas/xstormy16/gcc.sh
@@ -1,4 +1,4 @@
-#/bin/sh
+#!/bin/bash
# Generate test result data for xstormy16 GAS testing.
# It is intended to be run in the testsuite source directory.
#
--
2.17.1