This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] objdump: avoid shadowing a libiberty symbol

>>> On 25.06.19 at 10:03, <amodra@gmail.com> wrote:
> On Tue, Jun 25, 2019 at 12:53:52AM -0600, Jan Beulich wrote:
>> >>> On 24.06.19 at 21:31, <nick.alcock@oracle.com> wrote:
>> > On 24 Jun 2019, Jan Beulich outgrape:
>> >> --- a/binutils/objdump.c
>> >> +++ b/binutils/objdump.c
>> >> @@ -3207,10 +3207,10 @@ static char *
>> >>  dump_ctf_indent_lines (ctf_sect_names_t sect ATTRIBUTE_UNUSED,
>> >>  		       char *s, void *arg)
>> >>  {
>> >> -  char *spaces = arg;
>> >> +  char *spcs = arg;
>> > 
>> > Hm. "blanks" might be a better name?
>> 
>> Hmm, yes, fine with me. Will switch. I'd nevertheless hope I could get
>> approval to commit this without having to send a v2.
> 
> Sure, go ahead.

Thanks; I've extended this to the very similar readelf change as well,
but not to the slightly more different bfd/elf-properties.c and
ld/plugin.c ones.

Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]