This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] objdump: avoid shadowing a libiberty symbol
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "Nick Alcock" <nick dot alcock at oracle dot com>
- Cc: <binutils at sourceware dot org>
- Date: Tue, 25 Jun 2019 00:53:52 -0600
- Subject: Re: [PATCH] objdump: avoid shadowing a libiberty symbol
- References: <5D10C600020000780023A9E9@prv1-mh.provo.novell.com><5D10C600020000780023A9E9@prv1„mh.provo.novell.com> (Jan Beulich's message of "Mon, 24 Jun 2019 06:45:52 „0600") <87k1da93wj.fsf@esperi.org.uk>
>>> On 24.06.19 at 21:31, <nick.alcock@oracle.com> wrote:
> On 24 Jun 2019, Jan Beulich outgrape:
>> --- a/binutils/objdump.c
>> +++ b/binutils/objdump.c
>> @@ -3207,10 +3207,10 @@ static char *
>> dump_ctf_indent_lines (ctf_sect_names_t sect ATTRIBUTE_UNUSED,
>> char *s, void *arg)
>> {
>> - char *spaces = arg;
>> + char *spcs = arg;
>
> Hm. "blanks" might be a better name?
Hmm, yes, fine with me. Will switch. I'd nevertheless hope I could get
approval to commit this without having to send a v2.
Jan