This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH libctf] Fix a number of build problems found on Solaris and NetBSD
- From: Nick Alcock <nick dot alcock at oracle dot com>
- To: binutils at sourceware dot org
- Cc: Nick Clifton <nickc at redhat dot com>, Szabolcs Nagy <nsz at port70 dot net>, christophe dot lyon at linaro dot org, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, Simon Marchi <simark at simark dot ca>, Kamil Rytarowski <n54 at gmx dot com>, "Jose E. Marchesi" <jose dot marchesi at oracle dot com>
- Date: Thu, 30 May 2019 16:09:25 +0100
- Subject: Re: [PATCH libctf] Fix a number of build problems found on Solaris and NetBSD
- References: <8736kw2h5b.fsf@esperi.org.uk>
On 30 May 2019, Nick Alcock verbalised:
> - Use of nonportable <endian.h>
> - Use of qsort_r
> - Use of zlib without appropriate magic to pull in the binutils zlib
> - Use of off64_t without checking (fixed by dropping the unused fields
> that need off64_t entirely)
> - signedness problems due to long being too short a type on 32-bit
> platforms: ctf_id_t is now 'unsigned long', and CTF_ERR must be
> used only for functions that return ctf_id_t
> - One lingering use of bzero() and of <sys/errno.h>
>
> All fixed, using code from gnulib where possible.
This needs approval from someone with global write privs for the
binutils/objdump.c part. (I don't believe the include/ctf-api.h parts
need approval, but it would be nice for someone to glance at them
anyway.)
(Note: the objdump hunk will have a one-byte change to context if
applied before the reversion of Nick's
90bd54236cb8b1c31c3662977159be971044c20d, but no change in semantics.)