This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH libctf] Fix a number of build problems found on Solaris and NetBSD
- From: Nick Alcock <nick dot alcock at oracle dot com>
- To: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- Cc: "binutils\@sourceware.org" <binutils at sourceware dot org>, nd <nd at arm dot com>, "nickc\@redhat.com" <nickc at redhat dot com>, Szabolcs Nagy <nsz at port70 dot net>, "christophe.lyon\@linaro.org" <christophe dot lyon at linaro dot org>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, Simon Marchi <simark at simark dot ca>, Kamil Rytarowski <n54 at gmx dot com>, "Jose E. Marchesi" <jose dot marchesi at oracle dot com>
- Date: Thu, 30 May 2019 15:46:06 +0100
- Subject: Re: [PATCH libctf] Fix a number of build problems found on Solaris and NetBSD
- References: <8736kw2h5b.fsf@esperi.org.uk> <d1b292a7-15b3-df01-b55c-587f351e177c@arm.com>
On 30 May 2019, Szabolcs Nagy said:
> i cannot apply it on top of master, but i'd
> like to fix the build issue soon, so our
> builders can continue testing binutils.
The variant that applies on top of master has literally a
one-space-character difference outside ChangeLogs, fwiw, and that only
in the context of one hunk:
diff --git a/binutils/objdump.c b/binutils/objdump.c
--- a/binutils/objdump.c
@@ -127,7 +127,7 @@
@@
shdr_to_ctf_sect (ctf_sect_t *buf, Elf_Internal_Shdr *shdr, Filedata *filedata)
{
- buf->cts_name = SECTION_NAME(shdr);
+ buf->cts_name = SECTION_NAME (shdr);
- buf->cts_type = shdr->sh_type;
- buf->cts_flags = shdr->sh_flags;
buf->cts_size = shdr->sh_size;
The binutils/objdump.c parts need approval, but once I have that
approval I'll push whatever version is appropriate given the state of
master at the time (even if this makes it a bit harder to revert Nick's
no-libctf-when-no-ELF patches, the conflict above is trivial to
resolve).