This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH][Binutils][Arm] Fix Arm disassembler mapping symbol search.
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: "nickc at redhat dot com" <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
- Date: Thu, 7 Mar 2019 13:21:38 +0000
- Subject: RE: [PATCH][Binutils][Arm] Fix Arm disassembler mapping symbol search.
- References: <20190307114351.GA12572@arm.com> <398b7d25-d402-6156-c36d-606ca67723f3@redhat.com>
Hi Nick,
Sorry should have mentioned, but the patches are based on the other one for AArch64 that you approved before
https://sourceware.org/ml/binutils/2019-02/msg00098.html
I hadn't applied it yet as I noticed the issues after it was approved and didn't want a partial solution committed.
Cheers,
Tamar
> -----Original Message-----
> From: Nick Clifton <nickc@redhat.com>
> Sent: Thursday, March 7, 2019 12:56
> To: Tamar Christina <Tamar.Christina@arm.com>; binutils@sourceware.org
> Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
> Subject: Re: [PATCH][Binutils][Arm] Fix Arm disassembler mapping symbol
> search.
>
> Hi Tamar,
>
> > Ok for master? and for backport to binutils-2.32?
>
> Umm, I think that you might be missing a file from this patch.
> When I tried to build with it applied I get:
>
> opcodes/arm-dis.c: In function 'mapping_symbol_for_insn':
> opcodes/arm-dis.c:6392:9: error: 'struct disassemble_info' has no member
> named 'stop_offset'
> opcodes/arm-dis.c:6460:40: error: 'struct disassemble_info' has no member
> named 'stop_offset'
>
> Presumably there ought to be a patch to include/dis-asm.h as well ?
>
> Cheers
> Nick