This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] CSKY: Modify the default target vec

From: Lifang Xia <lifang_xia at c-sky dot com>
To: Nick Clifton <nickc at redhat dot com>, Alan Modra <amodra at gmail dot com>
Cc: binutils at sourceware dot org, 瞿仙淼 <xianmiao_qu at c-sky dot com>, 尚云海 <yunhai_shang at c-sky dot com>
Date: Fri, 4 Jan 2019 10:00:04 +0800
Subject: Re: [PATCH] CSKY: Modify the default target vec
References: <f1d8bcad-2805-5871-99a5-0d8be3e09a07@c-sky.com> <35de3412-6410-f72b-ba39-7de860901fdf@redhat.com>

Hi Nick,

Thanks for reviewing.

It is a mistake while doing the upstream. In the fact,
almost all C-SKY targets are in little endian mode.

So the csky_elf32_le_vec is more suitable.


On 2019年01月04日 01:25, Nick Clifton wrote:

Hi Lifang,

CSKY: Modify the default target vec

I am a little bit worried about this patch:

   csky-*-elf* | csky-*-linux* )
-    targ_defvec=csky_elf32_be_vec
+    targ_defvec=csky_elf32_le_vec
      targ_selvecs="csky_elf32_be_vec csky_elf32_le_vec"

Is it possible that there are users out there who are already
building toolchains with --target=csky-elf ?  If so they will
probably become confused when the default changes.

Cheers
   Nick


Best regards
Lifang Xia

Follow-Ups:
- Re: [PATCH] CSKY: Modify the default target vec
  - From: Nick Clifton

References:
- Re: [PATCH] CSKY: Modify the default target vec
  - From: Nick Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]