This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH gold/21066] Consider C++ exception handling metadata during ICF
- From: Cary Coutant <ccoutant at gmail dot com>
- To: oremanj at hudson-trading dot com
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 2 Oct 2018 16:35:43 -0700
- Subject: Re: [PATCH gold/21066] Consider C++ exception handling metadata during ICF
- References: <CAKKg2YOHOrST5oJ1yik4u3YNsgH=JBYY_7fe5tQcNK8p_YmywQ@mail.gmail.com>
> Two functions with the same code might not be combinable during ICF if
> they have different C++ exception handling metadata. PR gold/21066
> demonstrates this for the case where only the LSDA differs. New
> optimizations in GCC 8 can also create cases where the code is
> identical but the unwind tables differ; see gold/23482 for more
> details. This patch extends ICF to consider a function's associated
> FDE and CIE, including any relocations therein (e.g. to the LSDA),
> when deciding whether two functions are identical or not.
Thanks for the patch!
Before I can review it, however, we need a copyright assignment on
file with FSF. I looked, but didn't find one for you or your company.
Would you be willing to assign the copyright to the Free Software
Foundation? If so, I can send you the instructions for taking care of
that.
-cary