This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Re: Don't relax undefined symbols on ppc.
- From: Alan Modra <amodra at gmail dot com>
- To: Douglas B Rupp <rupp at adacore dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Mon, 27 Aug 2018 14:34:18 +0930
- Subject: Re: [PATCH] Re: Don't relax undefined symbols on ppc.
- References: <7ec3b35f-aeb9-d610-86f1-93d370f0660b@adacore.com> <20180710012728.GF3373@bubble.grove.modra.org> <cafc4672-a945-41c6-7e75-6b7e7959d82c@adacore.com> <20180724020119.GM3504@bubble.grove.modra.org> <b70cb89e-7794-f441-6eef-785c4f5422e7@adacore.com> <7f7a62fe-cfe7-d99e-48a6-69e2d43daf77@adacore.com> <20180724054019.GO3504@bubble.grove.modra.org> <003384b6-d9eb-9ae3-4143-164029f1e288@adacore.com>
On Fri, Jul 27, 2018 at 09:52:48AM -0700, Douglas B Rupp wrote:
> Btw, the reason for my moving the branch_fixup struct to static was to be
> able to dump the fixups to the map file later on. It was a customer
> enhancement request for us.
>
> Do you think this is a worthwhile enhancement to merge? I don't see how to
> do it easily without statically saving these fixups as they are created.
Yes, I do think this would be worth merging. You'll need a global
list separate from branch_fixups. branch_fixups should continue to
start from empty each ppc_elf_relax_section invocation, with
branch_fixups being tacked on to the global list rather than being
freed. Free the fixups after/during printing to the map file.
--
Alan Modra
Australia Development Lab, IBM