Re: [PATCH 1/2] gas/as.c: print input and output details when error

[Robert Yang <liezhi dot yang at windriver dot com>]

On 08/09/2018 06:29 PM, Rainer Orth wrote:
> Hi Robert,
>
> > > > Yes, I just realized that binutils maybe used on other platforms, so I
> > > > will avoid print that. Only print:
> > > >
> > > > "The input '%s' and output '%s' have the same inode"
> > >
> > > even the concept of inode is Unix-specific.  POSIX.1 talks of `file
> > > serial number'.  Best to avoid this in user-facing messages since it's
> > > just an irrelevant implementation detail, maybe say `... are the same
> > > file' or some such?
> >
> > There is a check "sib.st_ino != 0", I think that it can guarantee it is a
> > Unix-specific system, please ?
>
> no, you can't: st_ino is in POSIX.1, which is implemented by other
> systems as well.  In the end, the user doesn't care how you reached the
> conclusion that the files are identical; no need to expose this
> potentially unfamiliar term.

Thanks, I will update it to:

"The input '%s' and output '%s' are the same file"

// Robert

> 	Rainer