This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] gas/as.c: print input and output details when error



On 08/09/2018 05:22 PM, Andreas Schwab wrote:

On Aug 09 2018, Robert Yang <liezhi.yang@windriver.com> wrote:


as_fatal (_("The input '%s' and output '%s' have the same inode %ld"),
            argv[i],  sib.st_ino, saved_out_file_name))


st_ino is an opaque, filesystem internal number.  I have a hard time
figuring out why it would ever be useful to know.  Also, the correct
format to print it is very platform dependent, and likely incompatible
with %ld.


Yes, I just realized that binutils maybe used on other platforms, so I
will avoid print that. Only print:

"The input '%s' and output '%s' have the same inode"

Should be enough. V2 is coming.

// Robert



Andreas.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]